Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullref exception in expander refactoring #10168

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix nullref exception in expander refactoring #10168

merged 1 commit into from
May 22, 2024

Conversation

JanKrivanek
Copy link
Member

Fixes - insertion issue

Context

Dereferencing null can happen

D:\VS\src\ConfigData\BuildTargets\Microsoft.DevDiv.Common.Targets(800,5): error MSB4018: System.NullReferenceException: Object reference not set to an instance of an object. [D:\VS\src\edev\diagnostics\intellitrace\Tests\Functional\ProfilerTypeSpecTestsCodeGen\ProfilerTypeSpecTestsCodeGen.csproj]
D:\VS\src\ConfigData\BuildTargets\Microsoft.DevDiv.Common.Targets(800,5): error MSB4018:    at Microsoft.Build.Evaluation.OperatorExpressionNode.IsUnexpandedValueEmpty() [D:\VS\src\edev\diagnostics\intellitrace\Tests\Functional\ProfilerTypeSpecTestsCodeGen\ProfilerTypeSpecTestsCodeGen.csproj]

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9615450&view=logs&j=018464ba-1ca1-5561-2761-cd93078ac78a&t=3574efd9-071a-5092-469d-6ae99dc3b0cf&l=71278

@maridematte maridematte merged commit 1d47d30 into main May 22, 2024
10 checks passed
@maridematte maridematte deleted the bugfix/expander-fix branch May 22, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

@maridematte maridematte maridematte approved these changes

@YuliiaKovalova YuliiaKovalova YuliiaKovalova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JanKrivanek @rainersigwald @maridematte @YuliiaKovalova